Skip to content

Conversation

@albertomercurio
Copy link
Member

@albertomercurio albertomercurio commented Jan 28, 2025

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to QuantumToolbox.jl.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

I add some checks on the tlist argument. It throws an error if tlist is either empty, not sorted or containing repeated values.

Related issues or PRs

Fixes #377

@codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.41%. Comparing base (2f0ce8e) to head (37b7b9b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   93.32%   93.41%   +0.08%     
==========================================
  Files          43       43              
  Lines        2803     2809       +6     
==========================================
+ Hits         2616     2624       +8     
+ Misses        187      185       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytdHuang ytdHuang requested review from ytdHuang and removed request for ytdHuang January 29, 2025 02:15
@albertomercurio albertomercurio merged commit de31edb into qutip:main Jan 29, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect return state and expectation value for time evolution solvers with trivial tlist

2 participants