Skip to content

Conversation

@albertomercurio
Copy link
Member

@albertomercurio albertomercurio commented Jan 29, 2025

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to QuantumToolbox.jl.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

Here I move the code quality dependencies (Aqua.jl and JET.jl) to a separate environment. In this way we simplify the dependency structure of the package, trying to make it compatible to the Julia nightly tests (that were failing due to JET).

This is different from the implementation we adopted months ago, where we were running Pkg.add(["Aqua", "JET"]) with an increase of run test times. Here I actually create a separate environment for that, which allows to have everything already precompiled.

I have also changed the order of the tests. I think that having the core tests first is better, since we are first interested in the actual working changes, and only after in improving the code quality.

@codecov
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.41%. Comparing base (9ca0815) to head (b63c19b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #380   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files          43       43           
  Lines        2809     2809           
=======================================
  Hits         2624     2624           
  Misses        185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytdHuang ytdHuang merged commit bf7145d into qutip:main Jan 30, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants