Skip to content

Conversation

@albertomercurio
Copy link
Member

@albertomercurio albertomercurio commented Feb 8, 2025

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to Quantum Toolbox in Julia.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

I slightly improve the cache initialization of the pseudo inverse method of spectrum. This is also a test to see if the Benchmark Tracking still returns an error as in #386 .

Additional context

@albertomercurio albertomercurio added the Skip ChangeLog Skip changelog update check in PR label Feb 8, 2025
@albertomercurio albertomercurio removed the Skip ChangeLog Skip changelog update check in PR label Feb 8, 2025
@codecov
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (0408069) to head (23f38ae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files          44       44           
  Lines        2826     2827    +1     
=======================================
+ Hits         2645     2646    +1     
  Misses        181      181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertomercurio
Copy link
Member Author

Ok, the benchmarks passed. I don't know what happened.

@albertomercurio
Copy link
Member Author

Also in the main

@albertomercurio albertomercurio merged commit c5ee417 into qutip:main Feb 8, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants