Skip to content

Conversation

@albertomercurio
Copy link
Member

@albertomercurio albertomercurio commented Apr 6, 2025

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to Quantum Toolbox in Julia.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

The automatic differentiation is already supported for several functions. With this PR I add a rrule for ChainRulesCore.jl in order to support the QuantumObject type.

IMPORTANT

To be merged only after this issue is fixed.

@albertomercurio
Copy link
Member Author

Waiting also for this PR to be merged.

@albertomercurio albertomercurio changed the title Improve support to automatic differentiation and add related tests Add support to automatic differentiation for sesolve and mesolve Apr 8, 2025
@albertomercurio albertomercurio marked this pull request as ready for review April 11, 2025 22:14
@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.32%. Comparing base (54145bf) to head (35c1589).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/qobj/quantum_object_evo.jl 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
- Coverage   94.36%   94.32%   -0.04%     
==========================================
  Files          47       48       +1     
  Lines        2997     3015      +18     
==========================================
+ Hits         2828     2844      +16     
- Misses        169      171       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ytdHuang ytdHuang merged commit a07b991 into qutip:main Apr 12, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants