-
Notifications
You must be signed in to change notification settings - Fork 31
Improve Bloch sphere code structure and docs
#480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
==========================================
+ Coverage 93.67% 93.95% +0.27%
==========================================
Files 50 50
Lines 3414 3423 +9
==========================================
+ Hits 3198 3216 +18
+ Misses 216 207 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The Bloch sphere render in documentation doesn't seem correct even after your PR (the Do you have any idea ? |
|
Sorry about that, I submitted to fix as subcmmit here, I didn't used |
Co-authored-by: Alberto Mercurio <[email protected]>
|
Thank you very much for the improvements!! I’m very happy to see the Bloch sphere in the documentation!! :) |

Checklist
Thank you for contributing to
QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.make test.juliaformatted by running:make format.docs/folder) related to code changes were updated and able to build locally by running:make docs.CHANGELOG.mdshould be updated (regarding to the code changes) and built by running:make changelog.Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.
Description
There are still many things to improve in the previous PR #472.
LaTeXStringsto main package dependencies, so that we can set the LaTeX labels (LaTeXStringsdoesn't have other dependencies, so I think it is fine)Makieextension to the main packagesrc/visualization.jl(since those functions doesn't relate toMakie)Base.showforBlochand also improve theBase.showforSettingstogether.