Skip to content

Conversation

@ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Jun 9, 2025

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to Quantum Toolbox in Julia.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

This PR does:

  • set default font size to 20
  • add kwargs kind for add_states! (same as qutip)
  • improve the handling of plot vector arrow length.
  • fix all incorrect docstrings
  • merge the codes in _draw_reference_circles! and _draw_axes! into _draw_bloch_sphere!
  • remove redundant wire frame drawings

@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 98.03922% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.06%. Comparing base (22efb11) to head (9e7d544).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/visualization.jl 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #487      +/-   ##
==========================================
+ Coverage   93.97%   94.06%   +0.08%     
==========================================
  Files          50       50              
  Lines        3418     3418              
==========================================
+ Hits         3212     3215       +3     
+ Misses        206      203       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ytdHuang ytdHuang requested a review from albertomercurio June 9, 2025 12:34
@albertomercurio albertomercurio merged commit dc4ecde into main Jun 9, 2025
18 of 19 checks passed
@ytdHuang ytdHuang deleted the fix/bloch branch June 9, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants