Skip to content

Conversation

@matteosecli
Copy link
Contributor

@matteosecli matteosecli commented Jul 3, 2025

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to Quantum Toolbox in Julia.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

Check for breakdown of orthogonality and orthogonal initial vectors in the Lanczos solver.

Related issues or PRs

Fixes #501.

@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.97%. Comparing base (3028fe0) to head (aca80ff).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/spectrum.jl 76.47% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
- Coverage   94.22%   93.97%   -0.25%     
==========================================
  Files          50       50              
  Lines        3412     3421       +9     
==========================================
  Hits         3215     3215              
- Misses        197      206       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@albertomercurio
Copy link
Member

The code quality fails. I think you should use @warn "your text:

@matteosecli
Copy link
Contributor Author

The code quality fails. I think you should use @warn "your text:

Oops 🙈

@albertomercurio albertomercurio merged commit 0066cdb into qutip:main Jul 5, 2025
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors for handling breakdowns, or near breakdowns in the lanczos spectrum method.

2 participants