Skip to content

Conversation

@ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Aug 29, 2025

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to Quantum Toolbox in Julia.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

This PR introduces two new fields

  • terminate_reltol = 1e-5
  • terminate_abstol = 1e-7

for SteadyStateODESolver, in order to separate from the tolerances which pass to mesolve through steadystate(...; kwargs...).

Also, this PR fixes several kwargs handling for SteadyStateODESolver before passing to mesolve.

@ytdHuang ytdHuang marked this pull request as ready for review August 30, 2025 06:57
@codecov
Copy link

codecov bot commented Aug 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.19%. Comparing base (15954c9) to head (7ee2583).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
+ Coverage   94.16%   94.19%   +0.03%     
==========================================
  Files          51       51              
  Lines        3563     3565       +2     
==========================================
+ Hits         3355     3358       +3     
+ Misses        208      207       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@albertomercurio albertomercurio merged commit 75f33c4 into qutip:main Sep 1, 2025
17 of 18 checks passed
@ytdHuang ytdHuang deleted the fix/steadystateODE branch September 1, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants