Skip to content

Conversation

@albertomercurio
Copy link
Member

@albertomercurio albertomercurio commented Sep 24, 2025

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to Quantum Toolbox in Julia.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

This PR adds the feature of sorting the eigenvalues for the sparse solver through the keyword arguments sortby and rev. The former is also available for the dense solver case.

Related issues or PRs

Fixes #514

@albertomercurio albertomercurio marked this pull request as ready for review September 24, 2025 11:43
@albertomercurio albertomercurio changed the title Dev/patch 2 Add sortby and rev arguments to eigensolver functions Sep 24, 2025
@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.05%. Comparing base (be147e5) to head (dc7444e).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/qobj/eigsolve.jl 0.00% 7 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (be147e5) and HEAD (dc7444e). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (be147e5) HEAD (dc7444e)
8 3
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #546       +/-   ##
===========================================
- Coverage   93.15%   31.05%   -62.11%     
===========================================
  Files          51       50        -1     
  Lines        3566     3523       -43     
===========================================
- Hits         3322     1094     -2228     
- Misses        244     2429     +2185     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@albertomercurio
Copy link
Member Author

The error should not be related to this. I will rerun the tests tomorrow.

@albertomercurio albertomercurio merged commit 252e362 into qutip:main Sep 27, 2025
9 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sparse implementation of eigenenergies not sorting according to which

2 participants