Skip to content

Conversation

@ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Oct 25, 2025

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to Quantum Toolbox in Julia.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

As title

@ytdHuang ytdHuang marked this pull request as ready for review October 25, 2025 11:10
@ytdHuang
Copy link
Member Author

ytdHuang commented Oct 25, 2025

@albertomercurio

This could cause auto diff fail @@ ?

@albertomercurio
Copy link
Member

Only ForwardDiff is failing. Weird

@albertomercurio
Copy link
Member

Apparently times and times_states have different types when using ForwardDiff.jl

@albertomercurio albertomercurio merged commit 38351c8 into main Oct 26, 2025
16 of 19 checks passed
@ytdHuang ytdHuang deleted the sol-type branch October 26, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants