Skip to content

Conversation

@albertomercurio
Copy link
Member

As title

@albertomercurio albertomercurio added the Skip ChangeLog Skip changelog update check in PR label Oct 31, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces two key improvements to the eigenvalue solver:

  • Adds explicit sorting of eigenvalues and eigenvectors in the _eigsolve function to ensure results are ordered according to the sortby and rev parameters
  • Broadens the type constraint for the sigma parameter from Real to Number to support complex shift values in eigenvalue problems
Comments suppressed due to low confidence (2)

src/qobj/eigsolve.jl:283

  • The documentation string still shows sigma as Union{Nothing, Real}, but the actual function signature now accepts Union{Nothing, Number}. Update the documentation to reflect that sigma can accept complex numbers.
        sigma::Union{Nothing, Real}=nothing,

src/qobj/eigsolve.jl:298

  • The documentation parameter description shows Union{Nothing, Real}, but should be updated to Union{Nothing, Number} to match the function signature and indicate support for complex shift values.
- `sigma::Union{Nothing, Real}`: the shift for the eigenvalue problem. Default is `nothing`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@albertomercurio albertomercurio merged commit 75913c8 into qutip:main Nov 1, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip ChangeLog Skip changelog update check in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants