Skip to content

add the floquet solver test#646

Draft
bibekbh1 wants to merge 17 commits intoqutip:mainfrom
brisenodaniel:new-features
Draft

add the floquet solver test#646
bibekbh1 wants to merge 17 commits intoqutip:mainfrom
brisenodaniel:new-features

Conversation

@bibekbh1
Copy link

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to Quantum Toolbox in Julia.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

Describe the proposed change here.

Related issues or PRs

Please mention the related issues or PRs here. If the PR fixes an issue, use the keyword close/closes/closed/fix/fixes/fixed/resolve/resolves/resolved followed by the issue id, e.g. fix #[id]

Additional context

brisenodaniel and others added 14 commits January 6, 2026 11:55
Removed uneeded FloquetProblem struct. Created FloquetBasis struct and
constructors, added rudimetary documentation. Untested.
Added inline comments to FloquetBasis inner constructor and changed
Tuple tlist datatype to Vector. Vectors may be more performant for large arrays.
Wrote spec and implementation for various propagate functions, a struct
to contain the solution of time-evolution when using a FloquetBasis, and
the function signature for fsesolve. WARNING: All code is untested.
Changed behavior of propagator functions to only include initial and
final times in tlist provided to sesolve, after determining that the
DifferentialEquations.jl backend of QuantumToolbox dynamically
determines stepsizes and thus fine stepsizes in tlist are not needed to
improve accuracy. Began definition for states and modes.
@albertomercurio
Copy link
Member

Hi @bibekbh1,

Could you explain what you are doing in this PR?

@bibekbh1
Copy link
Author

bibekbh1 commented Feb 3, 2026 via email

@ytdHuang
Copy link
Member

ytdHuang commented Feb 4, 2026

Hi @bibekbh1,

Contributions are always welcome ! Please remember to read Contributing to Quantum Toolbox in Julia first.

However, it seems that this PR is still under development. Can you change this PR to draft PR first ? Otherwise, it keeps trigger the CI pipelines.

You can change it back when you think it is ready for us to review.

@albertomercurio
Copy link
Member

albertomercurio commented Feb 4, 2026

Hi @bibekbh1,

Thank you for the explanation.

I know that @Gavin-Rockwood is working on some related stuff. Especially on the propagator that will be then used for Floquet solvers.

Perhaps it is better to coordinate in order to avoid overlaps.

There is also this issue open #521

@bibekbh1 bibekbh1 marked this pull request as draft February 4, 2026 19:31
@bibekbh1
Copy link
Author

bibekbh1 commented Feb 4, 2026 via email

@Gavin-Rockwood
Copy link
Contributor

Hi @bibekbh1, yes! I have been working in that direction. Currently I am putting together a propagator structure similar to qutip, however I have been a bit busy the past couple of weeks with my day-to-day postdoc stuff. I am planning on jumping back into this in the next day or two and hopefully hammer it out. I'm down to chat about floquet implementations and the like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants