Conversation
Removed uneeded FloquetProblem struct. Created FloquetBasis struct and constructors, added rudimetary documentation. Untested.
Added inline comments to FloquetBasis inner constructor and changed Tuple tlist datatype to Vector. Vectors may be more performant for large arrays.
Wrote spec and implementation for various propagate functions, a struct to contain the solution of time-evolution when using a FloquetBasis, and the function signature for fsesolve. WARNING: All code is untested.
Changed behavior of propagator functions to only include initial and final times in tlist provided to sesolve, after determining that the DifferentialEquations.jl backend of QuantumToolbox dynamically determines stepsizes and thus fine stepsizes in tlist are not needed to improve accuracy. Began definition for states and modes.
b316f03 to
56424f1
Compare
|
Hi @bibekbh1, Could you explain what you are doing in this PR? |
|
Hi Alberto,
I apologize for that pull request, it was by mistake when we were setting
up our in-house development branch.
We (Dominic and I, Dominic in cc) were planning on reaching out to you
anyways, so while I have you here: we are developing a Floquet solver with
a similar API as the Floquet Basis in qutip 5.2.3. We are making this
branch for our own in-house needs but we are following the coding standards
of the larger QuantumToolbox.jl library, including API, testing, and
documentation practices. We would like to know if initiating a pull request
for the more refined floquet solver would be of interest to the
QuantumToolbox.jl team. Right now, we have only implemented unitary
dynamics. In the near future, we intend to add non-unitary dynamics.
Best regards,
Dominic and Bibek
…On Sat, Jan 31, 2026 at 5:59 AM Alberto Mercurio ***@***.***> wrote:
*albertomercurio* left a comment (qutip/QuantumToolbox.jl#646)
<#646 (comment)>
Hi @bibekbh1 <https://github.com/bibekbh1>,
Could you explain what you are doing in this PR?
—
Reply to this email directly, view it on GitHub
<#646 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5OMJ73QXM3DZD32CEU74C34JSYKLAVCNFSM6AAAAACRTM3ND6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMRYGU3TOMBTGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi @bibekbh1, Contributions are always welcome ! Please remember to read Contributing to Quantum Toolbox in Julia first. However, it seems that this PR is still under development. Can you change this PR to draft PR first ? Otherwise, it keeps trigger the CI pipelines. You can change it back when you think it is ready for us to review. |
|
Hi @bibekbh1, Thank you for the explanation. I know that @Gavin-Rockwood is working on some related stuff. Especially on the propagator that will be then used for Floquet solvers. Perhaps it is better to coordinate in order to avoid overlaps. There is also this issue open #521 |
|
Hi Alberto and Yi-Te,
Thank you very much for your email. I have changed
the PR to draft PR. We will get in contact with @Gavin-Rockwood
<https://github.com/Gavin-Rockwood> and let you know once the Floquet
solver is ready for review.
Best regards,
Bibek and Dominic
…On Wed, Feb 4, 2026 at 2:54 AM Alberto Mercurio ***@***.***> wrote:
*albertomercurio* left a comment (qutip/QuantumToolbox.jl#646)
<#646 (comment)>
Hi @bibekbh1 <https://github.com/bibekbh1>,
Thank you for the explanation.
I know that @Gavin-Rockwood <https://github.com/Gavin-Rockwood> is
working on some related stuff. Especially on the propagator that will be
then used for Floquet solvers.
Perhaps it is better to coordinate in order to avoid overlaps.
—
Reply to this email directly, view it on GitHub
<#646 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5OMJ75TG5SWJ5UZMFXJ5WL4KHFWHAVCNFSM6AAAAACRTM3ND6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNBWG4ZDOMZXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi @bibekbh1, yes! I have been working in that direction. Currently I am putting together a propagator structure similar to qutip, however I have been a bit busy the past couple of weeks with my day-to-day postdoc stuff. I am planning on jumping back into this in the next day or two and hopefully hammer it out. I'm down to chat about floquet implementations and the like! |
Checklist
Thank you for contributing to
QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.make test.juliaformatted by running:make format.docs/folder) related to code changes were updated and able to build locally by running:make docs.CHANGELOG.mdshould be updated (regarding to the code changes) and built by running:make changelog.Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.
Description
Describe the proposed change here.
Related issues or PRs
Please mention the related issues or PRs here. If the PR fixes an issue, use the keyword close/closes/closed/fix/fixes/fixed/resolve/resolves/resolved followed by the issue id, e.g. fix #[id]
Additional context