Skip to content

Conversation

@TendonFFF
Copy link
Collaborator

Checklist

Thank you for contributing to Tutorials for Quantum Toolbox in Julia! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to QuantumToolbox.jl.
  • The (last update) date were modified for new or updated tutorials.
  • All tutorials were able to render locally by running: make render.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

As title

@TendonFFF TendonFFF marked this pull request as ready for review January 14, 2025 12:23
@TendonFFF TendonFFF requested a review from ytdHuang January 14, 2025 14:38
@TendonFFF TendonFFF requested a review from ytdHuang January 15, 2025 02:51
Copy link
Member

@ytdHuang ytdHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are more things need to be addressed

Copy link
Member

@ytdHuang ytdHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tutorial you demonstrated is not "vacuum" Rabi oscillation

@ytdHuang ytdHuang self-requested a review January 17, 2025 01:16
Copy link
Member

@ytdHuang ytdHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay
a few more minor changes, and then I think the tutorial is ready

@TendonFFF TendonFFF requested a review from ytdHuang January 17, 2025 04:39
Copy link
Member

@albertomercurio albertomercurio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall you did a good job. I have just made some suggestion about the grammar.

@ytdHuang ytdHuang merged commit 328908b into qutip:main Jan 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants