New Design For General Decomposition Function#106
Draft
purva-thakre wants to merge 8 commits intoqutip:masterfrom
Draft
New Design For General Decomposition Function#106purva-thakre wants to merge 8 commits intoqutip:masterfrom
purva-thakre wants to merge 8 commits intoqutip:masterfrom
Conversation
10 tasks
Member
|
Thanks @purva-thakre, great to see this coming over! |
purva-thakre
commented
Nov 20, 2021
purva-thakre
commented
Nov 20, 2021
purva-thakre
commented
Jan 27, 2022
purva-thakre
commented
Feb 4, 2022
| ] | ||
|
|
||
| return gate_key_dict | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Add a function to make all control values consistent before the partial gray code gets split into n-bit toffoli and the gate needing decomposition.
If the function is used before _split_partial_gray_code then don't have to worry about searching for controls between the two split dictionaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will complete unfinished work from GSoC 2021. Linking closed PR's just in case - (gen_method, gray_code, two_qubit_test)
Because of the issue of nested dictionary etc, a new function will be added for every list of gates.
For example, if all control values have to be controlled on 1 then this gate information will be in a separate list, if SWAP gates have to be used to make a gate controlled on last qubit then this gate information will be kept separate and so on. More details will be added as the functions and respective tests are added.