Open
Conversation
madsgodvinjensen
added a commit
to understory-io/workflows
that referenced
this pull request
May 23, 2025
This is temporary while we wait for the maintainer of scan-imports to address the open PR: qwerqy/scan-imports#17
Author
|
@qwerqy Would you be able to have a look at this and decide if you'd want to integrate the changes into the project? |
Owner
|
Willl look into it today.
Thank you,
Amin Roslan
aminroslan.com
…On Mon, 16 Jun 2025 at 3:31 PM, Mads Godvin Jensen ***@***.***> wrote:
*madsgodvinjensen* left a comment (qwerqy/scan-imports#17)
<#17 (comment)>
@qwerqy <https://github.com/qwerqy> Would you be able to have a look at
this and decide if you'd want to integrate the changes into the project?
—
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMIV5HJISADHTUOHL3K7KL3DZXFXAVCNFSM6AAAAAB5YP4R4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNZVGQYDQOJZGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In modern libraries that use package exports a simple string match for the module name is not always enough.
This PR enables a regex mode where users can specify a pattern to match rather than a finite module name.