Add tests, name property, and merge everything into pyproject.toml#265
Add tests, name property, and merge everything into pyproject.toml#265
Conversation
also move everything into pyproject.toml (closes: 249)
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive testing infrastructure and migrates all project configuration to pyproject.toml. The PR introduces a test suite with 8 test files covering different components of the pypresence library, along with supporting test fixtures and configuration. It also adds a name property to presence updates and consolidates all project configuration into a single pyproject.toml file.
Key changes:
- Added comprehensive test suite with pytest configuration and fixtures
- Added support for
nameparameter in presence updates - Migrated all configuration from
setup.pyandsetup.cfgtopyproject.toml
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/ | Complete test suite with 8 test files covering all components |
| pyproject.toml | Consolidated project configuration including build, dependencies, and tool settings |
| setup.py | Simplified to legacy compatibility wrapper |
| pypresence/presence.py | Added name parameter support |
| pypresence/payloads.py | Added name parameter support |
| DEVELOPMENT.md | New comprehensive development guide |
| .github/workflows/ | Updated CI/CD configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| assert "none" not in result | ||
|
|
||
| def test_does_not_modify_original_dict(self): | ||
| """Test that original dictionary is modified in-place (by design)""" |
There was a problem hiding this comment.
The test name and docstring are contradictory. The test name suggests the original dict should not be modified, but the docstring says it's modified in-place by design. The test should clarify the actual expected behavior.
| """Test that original dictionary is modified in-place (by design)""" | |
| """Test that original dictionary is not modified by remove_none""" |
There was a problem hiding this comment.
This is okay. the 'does_not_modify' is referring to the fact that the remove_none should not change any other values, and just remove none. It's not contradictory.
pyproject.toml
Outdated
There was a problem hiding this comment.
Setting universal = true for bdist_wheel is incorrect for Python 3.9+ only packages. This should be universal = false since the package doesn't support Python 2.
| universal = true | |
| universal = false |
There was a problem hiding this comment.
Fixed in new commit
1 participant
No description provided.