fix: remove (imprecise) seconds->milliseconds conversion#271
Merged
kaneryu merged 3 commits intoqwertyquerty:masterfrom Nov 2, 2025
Merged
fix: remove (imprecise) seconds->milliseconds conversion#271kaneryu merged 3 commits intoqwertyquerty:masterfrom
kaneryu merged 3 commits intoqwertyquerty:masterfrom
Conversation
81e6e62 to
872ccba
Compare
Collaborator
|
Thanks for the work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new millisecond to second conversion code has an issue, the cast to int removes float precision. For example if you pass 1.5 seconds in it'll be turned into 1 second, then 1000 milliseconds. This caused my music progress duration to go up and down a second every time I updated it.
Rather than fix this, I think it'd be better to revert the
startandendarguments to be milliseconds again as changing them to seconds is a breaking change that I don't personally see being a benefit.This PR:
startandendarguments (integer) milliseconds again