Modify get_users to return all users in the user pool instead of just the first 60 #129
Open
jmking wants to merge 2 commits intoqwigo:masterfrom
Open
Modify get_users to return all users in the user pool instead of just the first 60 #129jmking wants to merge 2 commits intoqwigo:masterfrom
jmking wants to merge 2 commits intoqwigo:masterfrom
Conversation
added 2 commits
August 18, 2018 15:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_users currently advertises that it returns all users but in fact it only returns the first 60 due to the fact that client.list_users paginates after a limit of 60 users. I've changed it to pull all the users using the page token.
This seems reasonable to me but given this list could be large, it may be worth passing the page token back to the caller to allow them to pull each page themselves. This could be a seperate function perhaps. Any thoughts?