Changed 'add_base_attribute' method name into 'set_base_attribute'#134
Open
kritchie wants to merge 1 commit intoqwigo:masterfrom
Open
Changed 'add_base_attribute' method name into 'set_base_attribute'#134kritchie wants to merge 1 commit intoqwigo:masterfrom
kritchie wants to merge 1 commit intoqwigo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses GH-117 by refactoring the method name
add_base_attributetoset_base_attributePrior to this change, the
add_base_attributehad an idempotent definition :self.base_attributes = kwargsWhile the method declaration let's the user think that this method is indeed not idempotent by having the keyword
addin the method declaration. Setting it toset_base_attributewill remove potential errors from users.