Merge pull request #584 from maiieul/up-1.3.2

chore(update to 1.3.2): fix types

Author: thejackshelton

apps/website/src/routes/docs/headless/combobox/examples/search-bar.tsx

@@ -50,7 +50,7 @@ export default component$(() => {
         <ComboboxInput
           onClick$={() => (isListboxOpenSig.value = !isListboxOpenSig.value)}
           class="px-d2 bg-background placeholder:text-muted-foreground w-44 rounded-sm pl-6 pr-6"
-          onKeyDown$={(e: any) => {
+          onKeyDown$={(e: KeyboardEvent) => {
             if (e.key === 'Enter') {
               const inputElement = e.target as HTMLInputElement;
               window.location.href = `${docsPrefix}/${inputElement.value.toLowerCase()}`;

package.json

@@ -28,8 +28,8 @@
   },
   "packageManager": "[email protected]",
   "devDependencies": {
-    "@builder.io/qwik": "1.3.0",
-    "@builder.io/qwik-city": "1.3.0",
+    "@builder.io/qwik": "^1.3.2",
+    "@builder.io/qwik-city": "^1.3.2",
     "@builder.io/vite-plugin-macro": "~0.0.7",
     "@commitlint/cli": "^17.7.1",
     "@commitlint/config-angular": "^17.7.0",
@@ -86,7 +86,7 @@
     "eslint": "^8.48.0",
     "eslint-config-prettier": "9.0.0",
     "eslint-plugin-cypress": "^2.14.0",
-    "eslint-plugin-qwik": "1.3.0",
+    "eslint-plugin-qwik": "^1.3.2",
     "eslint-plugin-storybook": "^0.6.13",
     "focus-trap": "7.5.3",
     "husky": "^8.0.3",

packages/kit-headless/src/components/combobox/combobox-popover.tsx

@@ -10,7 +10,6 @@ export const ComboboxPopover = component$(
   (props: Partial<FloatingProps & PopoverImplProps>) => {
     const context = useContext(ComboboxContextId);
     const customPopoverId = useId();
-    console.log('customPopoverId:', customPopoverId);
     const { showPopover, hidePopover } = usePopover(customPopoverId);
 
     /* REMEMBER, whenever an option is selected or onMouseDown$ the listbox is closed, and the popover should sync to that */

packages/kit-headless/src/components/popover/floating.tsx

@@ -18,14 +18,13 @@ import {
   autoPlacement as _autoPlacement,
   hide as _hide,
 } from '@floating-ui/dom';
-import { OmitSignalClass } from '@qwik-ui/utils';
 
 declare global {
   interface Document {
     __NEEDS_POPOVER__?: true;
   }
   interface HTMLDivElement {
-    popover?: 'manual' | 'auto' | true;
+    popover?: 'manual' | 'auto';
   }
 }
 
@@ -59,7 +58,7 @@ export type FloatingProps = {
   hide?: 'referenceHidden' | 'escaped';
   inline?: boolean;
   transform?: string;
-} & OmitSignalClass<QwikIntrinsicElements['div']>;
+} & QwikIntrinsicElements['div'];
 
 export const FloatingPopover = component$(
   ({

packages/kit-headless/src/components/popover/popover-impl.tsx

@@ -17,7 +17,7 @@ import { supportShowAnimation, supportClosingAnimation } from './utils';
 
 export type PopoverImplProps = {
   id: string;
-  popover?: string | null | undefined;
+  popover?: 'manual' | 'auto';
   class?: ClassList;
   ref?: Signal<HTMLElement | undefined>;
   manual?: boolean;

packages/kit-headless/src/components/popover/popover-trigger.tsx

@@ -111,7 +111,6 @@ export const PopoverTrigger = component$<PopoverTriggerProps>(
     return (
       <button
         {...rest}
-        // @ts-expect-error bad types
         popovertarget={popovertarget}
         onClick$={[
           rest.onClick$,

packages/kit-headless/src/components/tabs/tab.tsx

@@ -1,7 +1,6 @@
 import {
   $,
   QwikIntrinsicElements,
-  Signal,
   Slot,
   component$,
   useComputed$,
@@ -85,10 +84,7 @@ export const Tab = component$<TabProps>(({ selectedClassName, tabId, ...props })
       onMouseEnter$={[selectIfAutomatic$, props.onMouseEnter$]}
       aria-selected={isSelectedSig.value}
       tabIndex={isSelectedSig.value ? 0 : -1}
-      class={[
-        (props.class as Signal<string>)?.value ?? (props.class as string),
-        classNamesSig.value,
-      ]}
+      class={[props.class, classNamesSig.value]}
       onClick$={[$(() => contextService.selectTab$(tabId!)), props.onClick$]}
     >
       <Slot />