Refactor: change row_factory from tuple to dict#161
Open
Manitary wants to merge 2 commits intor-anime:masterfrom
Open
Refactor: change row_factory from tuple to dict#161Manitary wants to merge 2 commits intor-anime:masterfrom
Manitary wants to merge 2 commits intor-anime:masterfrom
Conversation
Make arguments in class initialisation not order-sensitive Adjust existing calls to match the new format Assign some default values based on existing calls Fix inconsistent indentation
Manitary
force-pushed
the
test-database-keyword-args
branch
from
ae22257 to
b08843b
Compare
Supports both tuple and mapping, can be cast to dict if needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the comment about having order-sensitive arguments in classes initialisation so I gave it a try: by changing row_factory to a dict you can pass the result of the query as kwargs with **
I assigned some default values as I saw fit based on the existing code; there is some naming mismatch between the tables and the class attributes, I used some aliases as I did not want to propose changes that would require altering the schema.
I think I adjusted all instances affected by this change; by the logs, the modules
setup,edit,update, andepisodeseemed to work as intended.