Replace deprecated method datetime.utcnow#187
Open
Manitary wants to merge 1 commit intor-anime:masterfrom
Open
Replace deprecated method datetime.utcnow#187Manitary wants to merge 1 commit intor-anime:masterfrom
datetime.utcnow#187Manitary wants to merge 1 commit intor-anime:masterfrom
Conversation
Instead, call `datetime.now` with UTC tzinfo and remove the tzinfo Remove the `local` flag from `Episode.is_live` since it is a property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datetime.utcnowis deprecated with Python 3.12, and eventually will be removed (see here).Ideally everything should be made timezone-aware, but for now this commit simply replaces calls to
datetime.utcnow()by callingdatetime.now(UTC)and stripping the timezone information to make it naive, to keep the current behaviour.(also remove the
localflag fromEpisode.is_live, it is never used and it never could be since properties don't take arguments)