add propensity to imports and handle importing namespace#47
Merged
malcolmbarrett merged 2 commits intomainfrom Aug 5, 2025
Merged
add propensity to imports and handle importing namespace#47malcolmbarrett merged 2 commits intomainfrom
malcolmbarrett merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds propensity to the package imports and improves handling of propensity score weighting (psw) objects by loading the propensity namespace automatically and replacing workarounds with proper API calls.
- Added
propensityto package imports in DESCRIPTION - Added namespace loading in
.onLoad()to ensure psw S3 methods are available - Replaced
inherits(x, "psw")checks withpropensity::is_psw()calls - Removed
vctrs::vec_data()workarounds that were previously needed for psw objects
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| DESCRIPTION | Added propensity to package imports |
| R/zzz.R | Added .onLoad function to load propensity namespace |
| R/utils-validation.R | Updated psw object validation to use propensity::is_psw() |
| R/geom_roc.R | Removed vctrs::vec_data() workaround from examples |
| R/geom_qq2.R | Removed vctrs::vec_data() workaround from examples |
| man/geom_roc.Rd | Updated documentation examples |
| man/geom_qq2.Rd | Updated documentation examples |
| tests/testthat/test-extract_weight_data.R | Updated test to use propensity::is_psw() |
| tests/testthat/test-compute_balance.R | Updated tests to use propensity::is_psw() |
| tests/testthat/test-geom_roc.R | Removed vctrs::vec_data() workaround |
| tests/testthat/test-geom_qq2.R | Removed vctrs::vec_data() workaround |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.