Add weights for categorical exposures#34
Merged
malcolmbarrett merged 7 commits intomainfrom Aug 1, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive support for categorical exposures to propensity score weighting functions. The implementation enables weight calculation for multi-category treatments using matrix-based propensity scores and tilting functions specific to each estimand type.
Key changes include:
- Addition of categorical exposure support for all weight functions (ATE, ATT, ATU, ATM, ATO, Entropy)
- Implementation of propensity score matrix validation and column name handling
- Updates to error handling with new categorical-specific error classes
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/testthat/test-weights.R | Updates error classes from unsupported to matrix type errors for categorical exposures |
| tests/testthat/test-weights-categorical.R | Comprehensive test suite for categorical exposure weight calculations |
| tests/testthat/test-weights-categorical-comparison.R | Integration tests comparing results with WeightIt and PSweight packages |
| man/wt_ate.Rd | Documentation updates for categorical exposure support and focal parameter |
| R/weights.R | Core implementation of categorical weight calculations and estimand-specific logic |
| R/weights-utils.R | Utility functions for categorical exposure validation and matrix handling |
| DESCRIPTION | Addition of nnet package as suggested dependency |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12