Align handling of dbGetQuery without parameters to odbc::odbc()#30
Open
andrjohns wants to merge 3 commits intor-dbi:mainfrom
Open
Align handling of dbGetQuery without parameters to odbc::odbc()#30andrjohns wants to merge 3 commits intor-dbi:mainfrom
andrjohns wants to merge 3 commits intor-dbi:mainfrom
Conversation
Author
|
@krlmlr apologies for the ping, but does this fix look reasonable? We're looking to move to |
Member
|
Thanks. This change might be good for This is also something to review in the context of the DBI package: perhaps DBI could set this as a default too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
adbiwith theadbcsnowflakesnowflake driver currently fails to execute any queries unless theimmediate = TRUEargument is set.The
odbcpackage automatically sets theimmediateargument if theparamsargument is null, which also solves the error here