Skip to content

pr18191 #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −5
Open

pr18191 #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/library/tools/R/build.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,16 +278,20 @@ inRbuildignore <- function(files, pkgdir) {
if(file.exists(vignette_index_path))
unlink(vignette_index_path)

## this is not a logical field
## if (nchar(parse_description_field(desc, "VignetteBuilder", "")))
## ensure_installed()
## PR#18191: ensure tempory installation so can be checked for a vignette engine
if(desc["Package"] %in%
.get_requires_from_package_db(desc, "VignetteBuilder"))
ensure_installed()

## PR#15775: check VignetteBuilder packages are installed
## This is a bit wasteful: we do not need them in this process
loadVignetteBuilder(pkgdir, TRUE)
## PR#18191: ensure tempory installation directory is also checked
loadVignetteBuilder(pkgdir, TRUE, lib.loc = c(.libPaths(),libdir))


## Look for vignette sources
vigns <- pkgVignettes(dir = '.', check = TRUE)
## PR#18191: ensure tempory installation directory is also checked
vigns <- pkgVignettes(dir = '.', check = TRUE, lib.loc= c(.libPaths(),libdir))
if (!is.null(vigns) && length(vigns$docs)) {
ensure_installed()
## Good to do this in a separate process: it might die
Expand Down
Loading