Strip URL parameters for local filename #215
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
download.packages()copies the fullFilefield from the URL in PACKAGES, including http parameters, as the local filename. So for example, if thePACKAGESfile containsThen the file is saved locally not as
jsonlite_2.0.0.tar.gzbut as the full url including the?and=characters which are not allowed in filenames on some platforms.To reproduce this I created a testing repo:
The above patch makes the download behavior of R correspond to browsers, which is to remove the http-query part from the url when saving a file locally.