Syntax for underscore-separated numerals #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are green, and I can't think of anything else to add. Time to write the patch cover letter? @t-kalinowski, what do you think?
For extra style points, I'll try to predict the PR# right before posting the PR and patch in the same message. |
|
Look great to me! This will be a very nice addition to R. |
aitap
changed the title
Adjust the lexer to skip over underscores in numeric literals where it makes sense to do so.
Generating gram.c with a different version of Bison results in lots of changes, but we should be fine with updating just the same parts we'd changed in gram.y.
Document single underscores inside significand being ignored, give an example.
aitap
force-pushed
the
underscore_numerals
branch
from
f9c3fb2 to
b37228f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gram.yto allow numeric literals looking like1_000_000?NumericConstants