Extend Unicode support in ASCIIfy()#27
Merged
bbolker merged 2 commits intor-gregmisc:masterfrom Apr 17, 2025
arni-magnusson:master
Merged
Extend Unicode support in ASCIIfy()#27bbolker merged 2 commits intor-gregmisc:masterfrom arni-magnusson:master
bbolker merged 2 commits intor-gregmisc:masterfrom
arni-magnusson:master
Conversation
Contributor
|
Merged, thanks. How would you write a test/example for this? I'm worried about including the└ character in example/test files because of potential encoding issues ... ?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Ben,
The only thing more fun than drawing ASCII art is drawing UTF-8 art :)
Today, I wanted to ASCIIfy the └ character and was surprised that the ASCIIfy() function was choking on it. After a quick Heimlich maneuver, I modified a line in the code that allows it to convert a wider range of Unicode characters, including the highly useful └ character.
Reproducible example: