Skip to content

Extend Unicode support in ASCIIfy() #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbolker merged 2 commits into from
Apr 17, 2025
Merged

Extend Unicode support in ASCIIfy() #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30206a9
Extend Unicode support in ASCIIfy()
arni-magnusson Apr 14, 2025
325c31e
Merge branch 'master' into master
bbolker Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions R/ASCIIfy.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,12 @@ ASCIIfy <- function(x, bytes = 2, fallback = "?") {
} else {
ascii <- fallback
warning(char, " could not be converted to 1 byte")
}
} else if (length(raw) == 2 && bytes == 2) { # UTF-8 to \u0000
} # UTF-8 to \u0000
} else if (nchar(format.hexmode(utf8ToInt(char))) <= 4 && bytes == 2) {
ascii <- paste0("\\u", format.hexmode(utf8ToInt(char), width = 4))
} else {
ascii <- fallback
warning(char, " could not be converted to ", bytes, " byte")
warning(char, " could not be converted to ", bytes, " bytes")
}
return(ascii)
}
Expand Down
5 changes: 3 additions & 2 deletions inst/NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
gtools 3.9.6
--------------------------
gtools 3.9.6 - development
---------------------------

- improve `ASCIIfy()` so it handles a wider range of Unicode characters.
- add `hyphen.separator` argument to `mixedorder`/`mixedsort`

gtools 3.9.5 - 2023-11-20
Expand Down
Loading