Reverted to commit ca62a2d66.#5
Open
hakonhagland wants to merge 1 commit intor-gregmisc:develfrom
hakonhagland:fix_dzil_build
Open
Reverted to commit ca62a2d66.#5hakonhagland wants to merge 1 commit intor-gregmisc:develfrom hakonhagland:fix_dzil_build
hakonhagland wants to merge 1 commit intor-gregmisc:develfrom
hakonhagland:fix_dzil_build
Conversation
Let dzil build the files of the distribution. Commit 94d5a6e added files that should be generated by "dzil build". This commit deletes files added, and restores files which was modified to the version in commit ca62a2d. A small problem that this commit introduces is how to include the last commit c2ca1e9 ? This commit was added after 94d5a6e and modifies the README file. However the README file is currently generated by "dzil build" by plugin [Readme]. Some options to handle this is a) to remove the [Readme] plugin, such that the Readme file is not genereated. But this has a disadvantage that the README must be updated manually if the Copyright year or version of the module changes, b) write a custom plugin that modifies the generated README, c) use another plugin like [ReadmeAnyFromPod], d) put the added information in some other file, e) abandon the added infomration all together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let
dzilgenerate/modify the files of the distribution.Commit 94d5a6e added files that should be generated by
dzil build. This commit deletes the files added and restores files which was modified. The files are reverted to the version in commit ca62a2d.Now, this introduces a small problem of how to include the last commit c2ca1e9. This commit was added after 94d5a6e and modifies the
READMEfile slightly. However theREADMEfile is currently generated bydzil buildby plugin[Readme]. Some options to handle this is:[Readme]plugin such that theREADMEfile is not generated. This has a disadvantage that theREADMEfile must be updated manually if the copyright year or version of the module changes, orREADME(after it has been generated but still during thedzil build), or[ReadmeAnyFromPod], or