New coercion methods #192
Merged
New coercion methods #192
+439
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
OK, I think this is basically ready to go, thank you!! Take one last look at my latest edits/comments, should be minor. |
hcirellu
commented
Jan 6, 2026
Contributor
Author
|
I was surprised, that as.difftime.integer64 worked even though the generic as.difftime was not exported anymore. By checking it, I found out, that base::as.difftime automatically converts to double, if the input is numeric. And since is.numeric(integer64) is TRUE, no extra methods are necessary. I kept the tests, so that we are aware if something changes in R. |
Collaborator
Oh, perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #199
I added coercion methods for
Date,POSIXct,POSIXlt,complex,rawanddifftime. I also made the methods consistent regarding thekeep.namesargument.