Skip to content

Mark R_init_fs as visible#480

Merged
gaborcsardi merged 3 commits intor-lib:mainfrom
MichaelChirico:patch-2
Apr 25, 2025
Merged

Mark R_init_fs as visible#480
gaborcsardi merged 3 commits intor-lib:mainfrom
MichaelChirico:patch-2

Conversation

@MichaelChirico
Copy link
Copy Markdown
Contributor

See https://cran.r-project.org/doc/manuals/r-devel/R-exts.html#Controlling-visibility.

As it is, {fs} fails to compile under -fvisibility=hidden.

@jeroen
Copy link
Copy Markdown
Member

jeroen commented Apr 6, 2025

We should add PKG_CFLAGS=$(C_VISIBILITY) too, such that internal symbols from libuv do not polluate the namespace.

@gaborcsardi gaborcsardi merged commit 7731076 into r-lib:main Apr 25, 2025
20 checks passed
@gaborcsardi
Copy link
Copy Markdown
Member

Thank you!

@MichaelChirico MichaelChirico deleted the patch-2 branch May 5, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants