Add verbosity argument to req_peform_connection()#632
Merged
Conversation
hadley
commented
Jan 7, 2025
| if (include_trailer && length(buffer) > 0) { | ||
| return(buffer) | ||
| } else { | ||
| if (length(buffer) == 0) { |
Member
Author
There was a problem hiding this comment.
@jcheng5 I don't think I've changed the logic here, just tweaked it a bit so we can warn when we get an unexpected end of input.
hadley
commented
Jan 7, 2025
jcheng5
reviewed
Jan 9, 2025
| if (include_trailer) { | ||
| return(buffer) | ||
| } else { | ||
| cli::cli_warn("Premature end of input; ignoring final partial chunk") |
Member
There was a problem hiding this comment.
Would it make sense to log the buffer here, under certain verbosity levels?
Member
Author
There was a problem hiding this comment.
Do you think that's likely to be useful? i.e. going from raw bytes to understand what's gone wrong seems like it will be a challenge.
Member
Author
There was a problem hiding this comment.
What if we just enabled print_buffer() when verbosity >= 3?
jcheng5
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #599