Skip to content

Comments

Combine XPath filters in vector_logic_linter#3008

Merged
MichaelChirico merged 2 commits intomainfrom
vector-xpath-cleanup
Jan 22, 2026
Merged

Combine XPath filters in vector_logic_linter#3008
MichaelChirico merged 2 commits intomainfrom
vector-xpath-cleanup

Conversation

@MichaelChirico
Copy link
Collaborator

Follow-up to #3004 -- cc @emmanuel-ferdman this is what I had in mind; it passes current tests, WDYT?

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.23%. Comparing base (2e1b041) to head (2de0706).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3008      +/-   ##
==========================================
- Coverage   99.23%   99.23%   -0.01%     
==========================================
  Files         128      128              
  Lines        7287     7286       -1     
==========================================
- Hits         7231     7230       -1     
  Misses         56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emmanuel-ferdman
Copy link
Collaborator

emmanuel-ferdman commented Jan 20, 2026

@MichaelChirico Awesome, thanks for the clarifying. The [(A or B) and not(C)] form is definitely cleaner than the chained [A or B][not(C)] predicate. Tested your changes locally so LGTM.

@MichaelChirico MichaelChirico merged commit 689d6fe into main Jan 22, 2026
21 checks passed
@MichaelChirico MichaelChirico deleted the vector-xpath-cleanup branch January 22, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants