Replace all expect_lint(..., NULL, ...) by expect_no_lint(..., ...)#3009
Merged
MichaelChirico merged 7 commits intor-lib:mainfrom Jan 20, 2026
Merged
Replace all expect_lint(..., NULL, ...) by expect_no_lint(..., ...)#3009MichaelChirico merged 7 commits intor-lib:mainfrom
expect_lint(..., NULL, ...) by expect_no_lint(..., ...)#3009MichaelChirico merged 7 commits intor-lib:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3009 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 128 128
Lines 7287 7287
=======================================
Hits 7231 7231
Misses 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| expect_lint( | ||
| "list( | ||
| expect_no_lint("list( |
Collaborator
There was a problem hiding this comment.
let's use trim_some here too
| NULL, | ||
| linter_list | ||
| ) | ||
| expect_no_lint("(function(x, y) x + y)(x = 1) |
| @@ -1,5 +1,5 @@ | |||
| test_that("default styles are linted correctly", { | |||
| linters <- list( | |||
| linters <- list( | |||
| linter <- pipe_continuation_linter() | ||
| .cases <- tibble::tribble( | ||
| ~code_string, ~.test_name, | ||
| ~code_string, ~.test_name, |
Collaborator
There was a problem hiding this comment.
can't see this well but my memory is this whitespace was for clarity, I would revert. wdyt?
Collaborator
MichaelChirico
left a comment
MichaelChirico
left a comment
There was a problem hiding this comment.
Went through everything, just those two more nits about whitespace style.
Thanks!
Contributor
Author
|
Thanks, should be good to go now (hopefully I didn't forget a trailing whitespace ^^) |
MichaelChirico
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2737.
Follow-up of #2951.
@MichaelChirico I just found it easier to make a new PR rather than fixing all conflicts. I followed the same steps as detailed in #2951, including running
stylerat the end.