Implement call_is_undesirable parameter in undesirable_operator_linter#3015
Merged
MichaelChirico merged 1 commit intor-lib:mainfrom Feb 23, 2026
Merged
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3015 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 128 128
Lines 7288 7293 +5
=======================================
+ Hits 7232 7237 +5
Misses 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The
call_is_undesirableparameter was added in #2761 but never actually wired up - the linter always checked prefix calls regardless of the setting. Now when you passcall_is_undesirable = FALSE, prefix notation like:::(pkg, fun)is properly skipped while still catching infix usage likepkg:::fun.Fixes #2999