Skip to content

Comments

Implement call_is_undesirable parameter in undesirable_operator_linter#3015

Merged
MichaelChirico merged 1 commit intor-lib:mainfrom
emmanuel-ferdman:fix-call-is-undesirable
Feb 23, 2026
Merged

Implement call_is_undesirable parameter in undesirable_operator_linter#3015
MichaelChirico merged 1 commit intor-lib:mainfrom
emmanuel-ferdman:fix-call-is-undesirable

Conversation

@emmanuel-ferdman
Copy link
Collaborator

PR Summary

The call_is_undesirable parameter was added in #2761 but never actually wired up - the linter always checked prefix calls regardless of the setting. Now when you pass call_is_undesirable = FALSE, prefix notation like :::(pkg, fun) is properly skipped while still catching infix usage like pkg:::fun.

Fixes #2999

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.23%. Comparing base (e6b2834) to head (7c5a5b0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3015   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files         128      128           
  Lines        7288     7293    +5     
=======================================
+ Hits         7232     7237    +5     
  Misses         56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichaelChirico MichaelChirico merged commit bbbbd2e into r-lib:main Feb 23, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

undesirable_operator_linter(call_is_undesirable=FALSE) is not actually implemented

2 participants