Fix use_bioconductor = FALSE still hitting bioconductor.org on R 4.5+#852
Merged
gaborcsardi merged 3 commits intor-lib:mainfrom Mar 20, 2026
Merged
Fix use_bioconductor = FALSE still hitting bioconductor.org on R 4.5+#852gaborcsardi merged 3 commits intor-lib:mainfrom
gaborcsardi merged 3 commits intor-lib:mainfrom
Conversation
gaborcsardi
added a commit
to r-lib/pkgcache
that referenced
this pull request
Mar 20, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #851
Fixes the behavior where setting options(pkg.use_bioconductor = FALSE) still causes a network request to https://bioconductor.org/config.yaml, breaking installations in corporate firewall environments.
What was happening:
Inside cmc__get_repos(), bioconductor$get_repos() was called unconditionally to classify user-configured repos as "bioc" vs "cranlike" — regardless of the bioc argument. On R <= 4.4 this was harmless because the hardcoded R→Bioc version map returns immediately. On R 4.5+, the version isn't in that map (intentionally), so it falls through to a live HTTP fetch of the Bioconductor config YAML — which fails behind a firewall even when the user explicitly opted out of Bioconductor.
The fix:
One line. When bioc = FALSE, no Bioconductor code is touched. The downstream %in% check still works correctly — it just returns all FALSE, classifying everything as "cranlike" as expected.