Support Codeberg repositories#2843
Merged
hadley merged 3 commits intor-lib:mainfrom Jan 27, 2025
nfrerebeau:support-codeberg-repos
Merged
Support Codeberg repositories#2843hadley merged 3 commits intor-lib:mainfrom nfrerebeau:support-codeberg-repos
hadley merged 3 commits intor-lib:mainfrom
nfrerebeau:support-codeberg-repos
Conversation
hadley
approved these changes
Jan 25, 2025
tests/testthat/test-navbar.R
Outdated
| pkg <- pkg_navbar(github_url = "https://gitlab.com/r-lib/pkgdown") | ||
| expect_snapshot_output(navbar_components(pkg)) | ||
|
|
||
| pkg <- pkg_navbar(github_url = "https://codeberg.org/r-lib/pkgdown") |
Member
There was a problem hiding this comment.
I don't tihnk it's worth adding a snapshot test here as your code is already covered by the other tests, and snapshot tests are expensive to review.
Member
|
Just one last step: can you please add a bullet to the top of |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for code repositories hosted on Codeberg. This allows the
BugReportsandURLfields to be recognized for building links in the Navbar, Home Sidebar and reference pages.Fix for #2842.