scales::alpha() performance and color format ("character" or "native")#370
Open
zeehio wants to merge 2 commits intor-lib:mainfrom
Open
scales::alpha() performance and color format ("character" or "native")#370zeehio wants to merge 2 commits intor-lib:mainfrom
zeehio wants to merge 2 commits intor-lib:mainfrom
Conversation
It is more efficient now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is on top of:
It uses the improvements on
farverto makescales::alpha()much faster, avoiding the intermediate step of the numeric matrix.Besides, it adds an additional parameter
color_fmtto choose between a"character"output format or the"native"output format, used in nativeRaster objects.Proposed NEWS entry (not added to avoid trivial conflicts):
Related to: