Merge pull request #679 from lorenzwalthert/drop-as-character

- Speed improvement in caching (#679).

Author: lorenzwalthert

.github/workflows/benchmarking.yaml

@@ -70,7 +70,8 @@ jobs:
       - name: Prepare PR comment
         run: |
           mkdir -p bench/pr-comment
-          echo 'Here is how the current PR would change benchmark results:\n' > bench/pr-comment/info.txt
+          echo "Here is how the current PR would change benchmark results when merged into $GITHUB_BASE_REF:" > bench/pr-comment/info.txt
+          echo "$GITHUB_EVENT_PULL_REQUEST_HEAD_SHA" >> bench/pr-comment/info.txt
       - name: Run benchmarks
         run: Rscript -e 'bench::cb_run()'
       - name: Show benchmarks

NEWS.md

@@ -18,6 +18,8 @@
 
 - blank lines in function calls and headers are now removed, for the former only 
   when there are no comments before or after the blank line (#629, #630, #635).
+- speed improvement (~10%) when cache is activated because transformers are not 
+  captured as character anymore (#679).
 
 ## Minor changes and fixes
 

R/utils-cache.R

@@ -91,7 +91,6 @@ cache_make_key <- function(text, transformers) {
     text = hash_standardize(text),
     style_guide_name = transformers$style_guide_name,
     style_guide_version = transformers$style_guide_version,
-    style_guide_text = as.character(transformers),
     more_specs = as.character(transformers$more_specs) %>%
       set_names(names(transformers$more_specs))
   )

bench/01-declarations.R

@@ -27,8 +27,8 @@ plot_against_base <- function(new_bm,
         new_bm <- dplyr::bind_rows(reference, new_bm)
         stopifnot(nrow(new_bm) == 2)
         diff_in_percent <- round(100 * diff(new_bm$p50) / new_bm$p50[1])
-        pr_comment <- glue::glue("* {name}: {new_bm$p50[1]} -> {new_bm$p50[2]} ({diff_in_percent}%)\n")
-        cat(pr_comment, file = "pr-comment/info.txt", append = TRUE)
+        pr_comment <- glue::glue("* {name}: {round(new_bm$p50[1], 3)} -> {round(new_bm$p50[2], 3)} ({diff_in_percent}%)")
+        cat(pr_comment, file = "pr-comment/info.txt", sep = "\n", append = TRUE)
       }
     }
   }