Update vendered catch.h file to remove C++20 deprecated function #2060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failures appear to be unrelated to the change. |
|
Sorry I missed this — Kevin did #2097 which is a little more general. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have confirmed this update fixes issue #2047 on with rhub:
https://github.com/tylermorganwall/rayrender/actions/runs/13449546083/job/37581472753
Right now this is causing a compilation error on CRAN due to a deprecated function (https://cran.r-project.org/web/checks/check_results_rayrender.html) and this error will prevent any packages from using C++ catch.h unit tests.