Add input checking #2155
Merged
Add input checking #2155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1754
EmilHvitfeldt
approved these changes
Aug 1, 2025
Member
EmilHvitfeldt
left a comment
EmilHvitfeldt
left a comment
There was a problem hiding this comment.
looking good. found 1 oddity
| act <- quasi_label(enquo(object), label) | ||
| stopifnot(is.character(regexp), length(regexp) == 1) | ||
| stopifnot(is.character(act$val)) | ||
| check_character(object) |
Member
There was a problem hiding this comment.
this feels out of place, it is the only time we are checking the object using these checkers
Member
Author
There was a problem hiding this comment.
Agreed, but I wanted to preserve the behaviour of the existing code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1754
@EmilHvitfeldt can you please take a quick look? No need for a detailed review but this was me + claude code so worth checking a few to make sure we didn't over index on the wrong pattern.