✨ Error upkeep ✨ #2177
Merged
✨ Error upkeep ✨ #2177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using chores prompt, followed by a couple of human tweaks
olivroy
reviewed
Aug 6, 2025
R/skip.R
Outdated
| if (length(parts) != 2L) { | ||
| cli::cli_abort( | ||
| "{.arg spec} should be a comparison like '>=' and an R version separated by a space." | ||
| "{.arg spec} must be an valid version specification, like {.str >= 4.0.0}, not {.str spec}." |
Contributor
There was a problem hiding this comment.
Suggested change
| "{.arg spec} must be an valid version specification, like {.str >= 4.0.0}, not {.str spec}." | |
| "{.arg spec} must be an valid version specification, like {.str >= 4.0.0}, not {.str {spec}}." |
Just in case you didn't notice!
olivroy
reviewed
Aug 6, 2025
tests/testthat/_snaps/skip.md
Outdated
| skip_unless_r("idfjdij") | ||
| Condition | ||
| Error in `skip_unless_r()`: | ||
| ! `spec` must be an valid version specification, like ">= 4.0.0", not "spec". |
Contributor
There was a problem hiding this comment.
Suggested change
| ! `spec` must be an valid version specification, like ">= 4.0.0", not "spec". | |
| ! `spec` must be an valid version specification, like ">= 4.0.0", not "idfjdij". |
If you don't want to re-run snaps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using chores prompt, followed by a couple of human tweaks