Some notes on snapshot cleanup #2194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cderv
approved these changes
Aug 28, 2025
vignettes/snapshotting.Rmd
Outdated
| If this is a deliberate change, you can follow the advice in the message and update the snapshots for that file by running `snapshot_accept("pizza")`; otherwise you can fix the bug and your tests will pass once more. | ||
| (You can also accept snapshot for all files with `snapshot_accept()`). | ||
|
|
||
| If you delete the test, the corresponding snapshot will be remove the next time you run the tests. If you delete all snapshots in the file, the entire snapshot file will be deleted the next time you run all the tests. |
There was a problem hiding this comment.
Except when variants are used, right?
This is what I understood from the clarification in snapshot.R help addition.
In that case, the user is responsible for cleaning old, unused variants snapshot.
There was a problem hiding this comment.
If you delete the entire test, then all the variants will be cleaned up. But testthat can't know if only one variant is never exercised any more, so it will never delete a single variant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1615
@cderv does this help clarify behviour?