Better feedback when testing interactively

[hadley]

When a test passes, say so. Includes some refactoring to eliminate a vestigial method.

[claude]

Claude finished @hadley's task —— View job

---

Todo List

• Read and analyze changed files
• Check for potential bugs or issues
• Provide review feedback

Review Summary

The changes look good overall. The refactoring consolidates logic appropriately and provides better user feedback.

Potential issue in R/local.R:203:

withr::defer(reporter$end_reporter(), envir = .env)

This calls end_reporter() method which still exists in the base Reporter class but was removed from StopReporter. However, since StopReporter inherits from Reporter, this should still work but may not do what's intended.

Minor observations:

• The success message format change from "Test passed" to "Test passed with X successes" provides better information
• Moving issue reporting from add_result() to end_test() improves output batching
• Removal of stop_reporter parameter simplifies the API appropriately

LGTM with the caveat about the end_reporter() call.

---