Improve errors when a non-vector is passed to expect_vector.
#2229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `expect_vector` function delegates most of its logic to `vctrs::vec_assert`, which can throw one of two errors, `vctrs_error_assert` and `vctrs_error_scalar_type`. Only the former one was being handled, not the latter. This doesn't affect the behaviour of tests much, but it produces sub-par error messages and causes failing tests to terminate immediately rather than recording the error and continuing like other assertions do.
|
@plietar thanks for working on this! I turned the two failure tests into snapshot tests to capture the actual message, and that revealed we ended up double quoting the variable name. I added a very quick and dirty hack to fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
expect_vectorfunction delegates most of its logic tovctrs::vec_assert, which can throw one of two errors,vctrs_error_assertandvctrs_error_scalar_type.Only the former one was being handled, not the latter. This doesn't affect the behaviour of tests much, but it produces sub-par error messages and causes failing tests to terminate immediately rather than recording the error and continuing like other assertions do.
Fixes #2224