Skip to content

Conversation

@MichaelChirico
Copy link
Contributor

@MichaelChirico MichaelChirico commented Nov 24, 2025

c.f. current error we observe:

Error in `...`: Snapshot file names must be unique. `name` has already been used.

vs. now

Error in `...`: Snapshot file names must be unique. "pval-direction-both.svg" has already been used.

Introduced in #1592

@MichaelChirico
Copy link
Contributor Author

I'm unable to update the snapshot myself at the moment. I tried the recommended new testthat::snapshot_download_gh() helper, but was rebuffed:

Error in `gh::gh()`:
! GitHub API error (403): Must have admin rights to Repository.
ℹ Read more at <https://docs.github.com/rest/actions/workflow-jobs#download-job-logs-for-a-workflow-run>
Run `rlang::last_trace()` to see where the error occurred.

(PS, it's not clear to me from the docs how to use dest_dir -- which directory should I be targeting, exactly? the package top-level directory? or should it point to the _snaps directory?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant