Move up "add link to blog post" release bullet (#1847)

* Move up release bullet to add link to blog post

* add 'preemptive' to blog link bullet

Co-authored-by: Davis Vaughan <[email protected]>

* silence message in test (unrelated to this PR)

* Update snapshot

---------

Co-authored-by: Davis Vaughan <[email protected]>

Author: ateucher

R/release.R

@@ -137,12 +137,12 @@ release_checklist <- function(version, on_cran) {
     "Wait for CRAN...",
     "",
     todo("Accepted :tada:"),
+    todo("Add preemptive link to blog post in pkgdown news menu", type != "patch"),
     todo("`usethis::use_github_release()`"),
     todo("`usethis::use_dev_version(push = TRUE)`"),
     todo("`usethis::use_news_md()`", !has_news),
     todo("Finish blog post", type != "patch"),
-    todo("Tweet", type != "patch"),
-    todo("Add link to blog post in pkgdown news menu", type != "patch")
+    todo("Tweet", type != "patch")
   )
 }
 

tests/testthat/_snaps/release.md

@@ -33,12 +33,12 @@
       Wait for CRAN...
       
       * [ ] Accepted :tada:
+      * [ ] Add preemptive link to blog post in pkgdown news menu
       * [ ] `usethis::use_github_release()`
       * [ ] `usethis::use_dev_version(push = TRUE)`
       * [ ] `usethis::use_news_md()`
       * [ ] Finish blog post
       * [ ] Tweet
-      * [ ] Add link to blog post in pkgdown news menu
 
 ---
 
@@ -101,12 +101,12 @@
       Wait for CRAN...
       
       * [ ] Accepted :tada:
+      * [ ] Add preemptive link to blog post in pkgdown news menu
       * [ ] `usethis::use_github_release()`
       * [ ] `usethis::use_dev_version(push = TRUE)`
       * [ ] `usethis::use_news_md()`
       * [ ] Finish blog post
       * [ ] Tweet
-      * [ ] Add link to blog post in pkgdown news menu
 
 # construct correct revdep bullet
 
@@ -158,10 +158,10 @@
       Wait for CRAN...
       
       * [ ] Accepted :tada:
+      * [ ] Add preemptive link to blog post in pkgdown news menu
       * [ ] `usethis::use_github_release()`
       * [ ] `usethis::use_dev_version(push = TRUE)`
       * [ ] `usethis::use_news_md()`
       * [ ] Finish blog post
       * [ ] Tweet
-      * [ ] Add link to blog post in pkgdown news menu
 

tests/testthat/test-proj-desc.R

@@ -12,9 +12,10 @@ test_that("proj_desc_field_update() only messages when adding", {
 
 test_that("proj_desc_field_update() works with multiple values", {
   create_local_package()
+  # Add something to begin with
+  proj_desc_field_update("Config/Needs/foofy", "alfa", append = TRUE)
   withr::local_options(list(usethis.quiet = FALSE, crayon.enabled = FALSE))
 
-  proj_desc_field_update("Config/Needs/foofy", "alfa", append = TRUE)
   expect_snapshot({
     proj_desc_field_update("Config/Needs/foofy", c("alfa", "bravo"),
                            append = TRUE)