Add a {test} for ui_escape_glue() helper
#2171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a simple helper to escape curly braces for glue (`ui_escape_glue()` in `utils-ui.R`), then applied it in the relevant `pr_*()` functions. I used Positron Assistant and Google Gemini as a test on this, then revised their fixes significantly. Do you want to add a test for this in `manual-pr-functions.R`? Or I could automate this stuff with mocked github API calls if you want to go that far. Fixes r-lib#2107
And implicitly test the curly brace thing.
|
Doh, I forgot to change the target! I... guess this replaces #2169. Or I can close this and re-create the PR so it targets that branch. |
|
Just recording that if I fetch the initial PR, do > pr_fetch(2169)
✔ Setting active project to "/Users/jenny/rrr/usethis".
✔ Checking out PR r-lib/usethis/#2169 (@jonthegeek): "Escape curly braces in
`pr_title` ".
✔ Switching to branch "jonthegeek-fix-2107-escape_curlies".
> devtools::load_all()
ℹ Loading usethis
> pr_fetch()
✔ Setting active project to "/Users/jenny/rrr/usethis".
ℹ No PR specified ... looking up open PRs.
Which PR are you interested in? (0 to exit)
1: PR #2171 (@jonthegeek): "Add a {test} for `ui_escape_glue()` helper"
2: PR #2170 (@karawoo): "Add placeholder spot for mocked bindings"
3: PR #2169 (@jonthegeek): "Escape curly braces in `pr_title` "
4: PR #2071 (@eitsupi): "Support `suggests` field of standalone files"
5: PR #2049 (@focardozom): "document data "
6: PR #2001 (@olivroy): "Include file names in `challenge_uncommited_changes()`"
7: PR #1529 (@jennybc): "Shields.io experiment"
Selection: |
|
If you specify this number, it did the escape but then didn't glue. This fix ended up not actually being inside |
|
This solution LGTM! Do you want to add a NEWS bullet? We can either merge this one or you can update the original PR. Finish off one of them and I'll merge. |
@jennybc I added the `Fixes r-lib#2107` to the description, but it didn't retroactively link to the issue, so make sure that's showing in Development to auto-close.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was meant to be a PR into #2169, but I forgot to set that when I created this PR, so I'm closing that and moving here.
Added a simple helper to escape curly braces for glue (
ui_escape_glue()inutils-ui.R), then applied it in the relevantpr_*()functions. I used Positron Assistant (with Claude) and Google Gemini (using my personal setup) on this to test Positron Assistant, then revised their fixes significantly.pr_pause()thenpr_resume()shows the title of this PR properly, as doespr_fetch()(with no number).pr_fetch(2171)also shows this title properly.Fixes #2107.